Add diagnostic metadata regression tests#11
Open
Danservfinn wants to merge 1 commit into
Open
Conversation
Notime02
added a commit
to Notime02/TentOfTrials
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused diagnostic metadata regression coverage for the redaction/path-normalization contract requested in #1, and tightens the build diagnostic metadata generation so PR JSON does not leak local checkout, home, temp, user, or host details.
Fixes #1.
Changes
unittestcoverage for repository-relative/artifact paths..logd, non-relative references, and mismatches.diagnostic/build-c2c53e9d.jsonfrom the required localpython3 build.pyvalidation run. The encrypted.logdcould not be produced because encryptly preflight timed out in this environment; the JSON records that blocker.Testing
python3 -m unittest tests.test_diagnostic_metadata -vpython3 build.pydiagnostic/build-c2c53e9d.json, and committed the diagnostic JSON blocker.Checklist