Skip to content

Add diagnostic redaction regression tests#15

Closed
zjwjing wants to merge 1 commit into
Peter7896:mainfrom
zjwjing:main
Closed

Add diagnostic redaction regression tests#15
zjwjing wants to merge 1 commit into
Peter7896:mainfrom
zjwjing:main

Conversation

@zjwjing

@zjwjing zjwjing commented Jun 20, 2026

Copy link
Copy Markdown

Description

Adds regression tests for diagnostic redaction and path normalization.

Closes #1

Changes

  • Created ests/test_diagnostic_redaction.py with:
    • Artifact paths as repository-relative paths
    • No leakage of local paths, machine names, usernames
    • .logd reference matching
    • Missing file handling
    • Cross-platform compatibility (Windows/Unix)

Test Coverage

  • 12 test cases covering:
    • Path normalization
    • Redaction validation
    • Metadata structure
    • Error handling

Wallet Address

ETH: 0x8971bC40f06e90015C5e92d247c96BfB65C24Cc7

Add 23 regression tests covering:
- Path normalization (forward slashes, repo-relative, no Windows drive letters)
- Sensitive data redaction (home, username, hostname, temp, full commit hash)
- Artifact pairing (.logd reference matches actual file)
- Missing file handling (clear failure when JSON/.logd missing or mismatched)
- build.py integration (required functions, UTC timestamps, no hardcoded passwords)
- Edge cases for cross-platform path normalization

All 23 tests pass. Addresses Issue #1.
@zjwjing

zjwjing commented Jun 22, 2026

Copy link
Copy Markdown
Author

Superseded by #17 (refactored version with full diagnostic-redaction regression suite). Same intent; #17 splits the change into smaller commits and adds 4 extra edge-case tests. Please continue review on #17.

@zjwjing zjwjing closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[$40 BOUNTY] [Python] Add diagnostic redaction regression tests

1 participant