[SOLUTION] Add protocol frame codec recovery tests for $50 bounty#25
Open
feezy1357 wants to merge 4 commits into
Open
[SOLUTION] Add protocol frame codec recovery tests for $50 bounty#25feezy1357 wants to merge 4 commits into
feezy1357 wants to merge 4 commits into
Conversation
Adds comprehensive tests for AuthMiddleware, RateLimitMiddleware, token bucket, middleware ordering, and the full middleware chain. - AuthMiddleware tests: missing/empty/valid/invalid tokens - RateLimitMiddleware tests: under/over limit, per-client buckets - Middleware ordering: auth before rate limiting - Token bucket unit tests: initial state, refill, empty - Token extraction: Bearer, API-Key, precedence Fixes jackjin1997#2
Adds comprehensive recovery and regression tests: - Reject truncated headers/payloads without panicking - Reject excessive payload lengths with clear errors - Reject unsupported versions - Verify checksum mismatch yields clear errors - Assert failed decode doesn't corrupt decoder state - Confirm valid frame after invalid input still decodable - Deterministic tests runnable on all platforms Fixes Peter7896#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution for [$50 BOUNTY] Add protocol frame codec recovery tests
Changes
Added comprehensive recovery and regression tests to
backend/src/protocol/codec.rs:Truncated frame rejection (no panic):
Invalid size rejection:
MessageTooLargeerrorVersion validation:
UnsupportedVersionUnsupportedVersionIntegrity checks:
ChecksumMismatcherrorchecksum = NoneDecoder state preservation:
Recovery after failure:
Determinism:
All tests are deterministic and platform-independent.
Closes #2