Add deterministic diagnostic redaction tests#28
Open
ringotokens-commits wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TentOfTrials Diagnostic Bounty PR Draft
Issue: #1
Patch: /Users/aiagent/Documents/Codex/2026-07-08/yo/outputs/tentoftrials_diagnostic_bounty.patch
Diagnostic artifacts:
Summary
Adds deterministic regression coverage for diagnostic metadata redaction, repository-relative path reporting, and
.logd/JSON artifact pairing. Also fixesmacos-x64encryptly detection so diagnostics can run on Intel macOS when the bundled binary is present.Changes
/separators.validate_diagnostic_metadata()to produce clear errors for missing JSON, missing.logd, absolute paths, backslash paths, and mismatched artifact extensions.unittestcoverage intests/test_diagnostics.py.macos-x64to the bundled encryptly platform map.Testing
Result:
Result: diagnostics now run and produce a matched JSON/logd pair, but the full build exits
1in this environment because several language toolchains are not installed and one C module fails to compile locally.Generated diagnostic pair:
diagnostic/build-fc78a64d.jsondiagnostic/build-fc78a64d.logdDiagnostic password printed by the build:
Validation helper result:
Checklist
Note: full build failure is due to local environment/toolchain availability (
cargo,go,cmake,luac,ghc, Java runtime) plus an existing C compile error, not the diagnostic tests./claim #1