fix: correct FRAME_HEADER_SIZE (24→20) + add protocol frame codec recovery tests#31
Open
dev-khimesh wants to merge 6 commits into
Open
fix: correct FRAME_HEADER_SIZE (24→20) + add protocol frame codec recovery tests#31dev-khimesh wants to merge 6 commits into
dev-khimesh wants to merge 6 commits into
Conversation
…ec recovery tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix pre-existing frame header size bug and add 9 deterministic regression tests for protocol frame codec recovery.
Bug Fix
FRAME_HEADER_SIZEwas incorrectly set to 24 but the actual wire format header is only 20 bytes (magic:4 + version:1 + type:1 + flags:2 + payload_len:4 + sequence:4 + reserved:4). This mismatch caused ALL existing codec tests to fail because the decoder waited for 4 extra bytes that never arrived.Tests Added (13 total, all pass)
Ok(None)without panickingErr(MessageTooLarge)Err(InvalidMessage), bad version →Err(UnsupportedVersion)decode_all()collects all framesreset()preserves future decode capabilityValidation
Closes #2