Add diagnostic redaction regression tests#5
Conversation
|
Thanks for the PR. The test direction is aligned with the diagnostic-redaction issue, but this is not bounty-ready yet because the required encrypted diagnostic log is missing. The PR currently commits |
ghost
left a comment
There was a problem hiding this comment.
Thanks for the PR. I found diagnostic JSON metadata, but I don't see the encrypted build diagnostic log artifact (*.logd / builds.compact) committed on this branch yet. Please rerun the build diagnostic/encryption step with the fixed encryptly tooling and commit the generated encrypted log artifact to this PR (typically under diagnostic/).
Blocking review until the encrypted diagnostic log artifact is present.
Summary
Closes #1
Adds deterministic regression coverage around diagnostic metadata redaction, repository-relative artifact paths, and JSON-to-
.logdpairing validation.Changes
build.pyto redact local-only values from diagnostic metadata text./paths when building the report.validate_diagnostic_metadata()to fail clearly for missing JSON, missing.logd, mismatched paths, absolute paths, backslashes, or local value leaks.python3 build.pyfor this branch commit.Testing
python -m unittest tests.test_diagnostic_redaction -v- passed on Windows.python -m compileall build.py tests\test_diagnostic_redaction.py- passed on Windows.git diff --check- passed.python3 -m unittest tests.test_diagnostic_redaction -v- passed under Ubuntu WSL.python3 build.py- executed under Windows and Ubuntu WSL; both attempts reached the diagnostic preflight butencryptlytimed out after 60s before creating an encrypted.logd. The generated metadata is committed atdiagnostic/build-7cf6d071.jsonand records the blocker.Checklist
encryptlytimed out before producing.logd; generated JSON metadata is committed)