Conversation
wutwasthat
commented
Dec 19, 2023
wutwasthat
commented
- Changes to adapt pyqtgraph
- Enables multiple lines drawing
- Pyqtgraph repo URL: https://github.com/wutwasthat/pyqtgraph/tree/physio
…nto optimization # Conflicts: # physiolabxr/utils/video_capture_utils.py
ApocalyVec
left a comment
ApocalyVec
left a comment
There was a problem hiding this comment.
This is great, I didn't find any issues with this PR. I suggest creating a pull request in pyqtgraph from https://github.com/wutwasthat/pyqtgraph.git@physio, so that this version of pyqtgraph can be officially supported. And the community can benefit from "plotting multiple lines in one call".
ApocalyVec
left a comment
ApocalyVec
left a comment
There was a problem hiding this comment.
Error encounter when using stream srate is set to 1366 in the StreamOptionWindow.
To reproduce, start the LSLOutletExample (doesn't matter # channels and its actual srate). Start PhysioLabXR, add the stream, start streaming, open StreamOptionWindow and set the "nominal sampling rate" to 1366. The exception occurs at line 211 of GroupPlotWidget:
Exception('X array and Y matrix must be the same shape--got (119,) and ( ,238).')
These numbers are not always the same, they depend on the srates.
I recommend using test/PerformanceBenchmark.py -> test_stream_visualization_dummy_streams_performance to test if everything checks out. This tests sweeps through streams with different srates.
Fixed. Performance test file seems to be running a very very very long time, not sure if it's suppose to or something is happening. |
3 participants
