fix(mock-amm): prevent mainnet initialization of test-only AMM - #65
Merged
Junman140 merged 3 commits intoAug 19, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…t-guard # Conflicts: # Stellar-contracts-v1/mock-amm/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mock-ammis documented as test-only but had no runtime check preventing it from being initialized on the public Stellar network.MockAmm::initializenow comparesenv.ledger().network_id()against the known Stellar mainnet passphrase hash and rejects the call withError::MainnetNotSupportedif it matches, so any mainnet initialization attempt fails on-chain.scripts/deploy_mainnet.shpreviously had aDEPLOY_AMM=trueflag that would upload, deploy, and initializemock-ammon mainnet. That path is now rejected up front inrequire_mainnet_inputs, and the associated dead deployment code has been removed from the script.Test plan
closes #24