Skip to content

fix: remove stale .env.example entries and align S3 env vars with code #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Junman140 merged 1 commit into from
Jun 26, 2026
Merged

fix: remove stale .env.example entries and align S3 env vars with code #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,21 +60,22 @@ USDC_ISSUER_MAINNET=GA5ZSEJYB37JRC5AVCIA5MOP4RHTM335X2KGX3IHOJAPP5RE34K4KZVN
# Slippage tolerance for USDC→XLM DEX swap (basis points; 50 = 0.5%)
USDC_XLM_SLIPPAGE_BPS=50
# Bulk transfer CSV chunk size (rows per transaction chunk; default 100)
BULK_TRANSFER_CHUNK_SIZE=100
# BULK_TRANSFER_CHUNK_SIZE=100
# Bulk transfer upload limit in bytes (default 10485760 = 10 MiB)
BULK_TRANSFER_MAX_FILE_SIZE_BYTES=10485760
# BULK_TRANSFER_MAX_FILE_SIZE_BYTES=10485760
# Minting contract: initialize with the SAC contract address for this issuer+code so mint_from_usdc matches the DEX asset; ensure a testnet path from that asset to XLM exists.

# ── S3 / KYC document storage (B-062) ────────────────────────────────────────
# S3 bucket for KYC document uploads (must be private — no public access)
AWS_S3_KYC_BUCKET=acbu-kyc-documents
# S3_BUCKET=acbu-kyc-documents
# AWS region for S3 (defaults to AWS_REGION if set)
AWS_S3_REGION=us-east-1
# AWS_REGION=us-east-1
# S3_REGION=us-east-1
# Explicit credentials — omit to use IAM role / instance profile in production
AWS_ACCESS_KEY_ID=your-access-key-id
AWS_SECRET_ACCESS_KEY=your-secret-access-key
# Optional: S3-compatible endpoint for local dev (e.g. MinIO)
# AWS_S3_ENDPOINT=http://localhost:9000
# S3_ENDPOINT=http://localhost:9000
Comment on lines 68 to +78

@coderabbitai coderabbitai Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- .env.example relevant slice ---'
nl -ba .env.example | sed -n '60,90p'

echo
echo '--- search S3 env references ---'
rg -n --hidden --glob '!.git' 'S3_BUCKET|S3_REGION|S3_ENDPOINT|AWS_REGION|AWS_ACCESS_KEY_ID|AWS_SECRET_ACCESS_KEY' .

Repository: Pi-Defi-world/acbu-backend

Length of output: 240

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- .env.example relevant slice ---'
nl -ba .env.example | sed -n '60,90p'

echo
echo '--- search S3 env references ---'
rg -n --hidden --glob '!.git' 'S3_BUCKET|S3_REGION|S3_ENDPOINT|AWS_REGION|AWS_ACCESS_KEY_ID|AWS_SECRET_ACCESS_KEY' .

Repository: Pi-Defi-world/acbu-backend

Length of output: 240

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- .env.example relevant slice ---'
sed -n '60,90p' .env.example

echo
echo '--- search S3 env references ---'
rg -n --hidden --glob '!.git' 'S3_BUCKET|S3_REGION|S3_ENDPOINT|AWS_REGION|AWS_ACCESS_KEY_ID|AWS_SECRET_ACCESS_KEY' .

Repository: Pi-Defi-world/acbu-backend

Length of output: 2882

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- s3.bucket usages ---'
rg -n --hidden --glob '!.git' 's3\.bucket|env\.s3\.bucket|S3_BUCKET' src ENV_VARS.md

echo
echo '--- env.ts S3 block ---'
sed -n '150,175p' src/config/env.ts

Repository: Pi-Defi-world/acbu-backend

Length of output: 2072

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- s3.bucket usages ---'
rg -n --hidden --glob '!.git' 's3\.bucket|env\.s3\.bucket|S3_BUCKET' src ENV_VARS.md

echo
echo '--- env.ts S3 block ---'
sed -n '150,175p' src/config/env.ts

Repository: Pi-Defi-world/acbu-backend

Length of output: 2072

Keep S3_BUCKET active in .env.example:68-78.

src/config/env.ts uses S3_BUCKET for every S3 operation, and it defaults to an empty string when unset. S3_REGION can stay commented because AWS_REGION already covers the default region, but the bucket name should be visible for fresh setups.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.env.example around lines 68 - 78, The `S3_BUCKET` example is commented out
in `.env.example`, but `src/config/env.ts` expects it for S3 usage and falls
back to an empty value when missing. Keep `S3_BUCKET` active and visible in the
example so fresh setups know to set it, while leaving `S3_REGION` commented
since `AWS_REGION` already provides the default.

# Presigned URL TTLs (seconds). Defaults: 900 upload, 300 download
# S3_UPLOAD_URL_TTL_SECONDS=900
# S3_DOWNLOAD_URL_TTL_SECONDS=300
Expand Down
Loading