Wasm

[somgoli]

Fixed. The verify_source_hashes() function now fails the build with process::exit(1) instead of printing a warning when a source file cannot be read. This ensures the build fails fast if source files are missing or unreadable, preventing runtime failures
Closes #341
the current implementation is correct. The issue entry should be marked as invalid or the description should be corrected.
Closes #344
All public functions now have comprehensive doc comments following Rust documentation conventions, which will improve the generated Soroban SDK documentation for frontend and backend developers.
Closes #372

Summary by CodeRabbit

• Bug Fixes
  • Improved build validation so missing source files now stop the build immediately with a clear error instead of only showing a warning.
  • Minor internal formatting cleanup with no effect on app behavior.

[drips-wave]

@somgoli Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 14e83da0-e003-4593-b25d-a2fd1ad506cd

📥 Commits

Reviewing files that changed from the base of the PR and between b98a67d and dc845b6.

📒 Files selected for processing (2)

• acbu_escrow/src/lib.rs
• build.rs

---

📝 Walkthrough

Walkthrough

build.rs upgrades a file-read failure in verify_source_hashes() from a cargo:warning to a hard build error (error[build]: ... + process::exit(1)). acbu_escrow/src/lib.rs has a whitespace-only indentation adjustment with no behavioral change.

Build hardening and whitespace fix

Layer / File(s)	Summary
Hard build error on unreadable tagged source build.rs	verify_source_hashes() now emits error[build]: Could not read ... and exits with status 1 instead of a cargo:warning when a tagged source file cannot be read.
Whitespace adjustment in Escrow::create acbu_escrow/src/lib.rs	Indentation of the env.storage() line in the CEI state-write block is corrected; no logic or behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Pi-Defi-world/acbu-smart-contract#160: Modifies the same build-time WASM/hash integrity verification path in build.rs.

Poem

🐇 A warning once whispered, now shouts with a boom,
"I cannot read this file — there's an error, make room!"
The indentation tidied, the spaces aligned,
Small fixes like these keep the contract refined.
Hop hop, little bug, the build shall not pass! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR only changes build.rs error handling and a whitespace line, leaving #341 and #372 unaddressed and #344 only partially covered.	Implement the escrow approval fix, add doc comments to public entry points, and ensure the WASM hash mismatch itself fails the build.
Title check	❓ Inconclusive	The title is too vague to identify the main change and does not describe the PR clearly.	Rename it to summarize the primary change, such as failing the WASM build on source/hash check errors.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check	✅ Passed	The changes are limited to the documented build.rs fix and a whitespace-only lib.rs edit, with no clear unrelated additions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}