Fix ParameterDescription of exclusive bounds#339
Open
christophfroehlich wants to merge 6 commits intomainfrom
Open
Fix ParameterDescription of exclusive bounds#339christophfroehlich wants to merge 6 commits intomainfrom
christophfroehlich wants to merge 6 commits intomainfrom
Conversation
christophfroehlich
added
the
backport-humble
christophfroehlich
force-pushed
the
fix/description/exclusive-bounds
branch
from
caaaa4a to
6b96a63
Compare
ottojo
approved these changes
Apr 17, 2026
Contributor
ottojo
left a comment
ottojo
left a comment
There was a problem hiding this comment.
That looks like it will fix the issue i reported! (Haven't built and tested it so far, myself i can do that next week).
I remember when looking into it before i came across std::nextafter, but i'm not sure if that is any different, the +/- epsilon is definetly more readable 👍
Collaborator
Author
|
Oh, |
Collaborator
Author
|
@ottojo have you had a chance to give that PR a try? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256