Fix install paths#348
Draft
christophfroehlich wants to merge 4 commits intomainfrom
Draft
Conversation
This was referenced Apr 18, 2026
saikishor
approved these changes
Apr 22, 2026
Contributor
saikishor
left a comment
There was a problem hiding this comment.
As far as I understood, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was completely coded by GPT-5.3-Codex and needs proper review and testing.
Summary
Fix Python generated-parameter module installation/import behavior across all colcon layouts (standard, isolated, and merge-install), resolving intermittent prerelease import failures.
Problem
Tests could fail with:
ModuleNotFoundError: No module named 'generate_parameter_module_example.admittance_parameters'ModuleNotFoundError: No module named 'generate_parameter_module_example.custom_validation'Root causes were path/layout mismatches in generation output handling and empty package
__init__.pyfiles in install space.Changes
Updated src/generate_parameter_library/generate_parameter_library_py/generate_parameter_library_py/setup_helper.py:
--opt valueand--opt=value)--build-lib,--install-lib,--prefix,--root)build*roots to matchinginstall*roots (includingbuild_isolated->install_isolated)AMENT_PREFIX_PATHUpdated src/generate_parameter_library/generate_parameter_library_py/generate_parameter_library_py/generate_python_module.py:
__init__.pywith namespace path extension when missing or emptyAdded src/generate_parameter_library/example_python/generate_parameter_module_example/init.py:
Validation
All scenarios pass for
generate_parameter_module_example:48 passed, 0 failed--build-base/--install-base):48 passed, 0 failed--merge-install):48 passed, 0 failedGenerated module is now written to the correct install location in each layout.