Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenRewrite 3.2.0 -> 3.3.0 #1557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Picnic-DevPla-Bot
Copy link
Contributor

@Picnic-DevPla-Bot Picnic-DevPla-Bot commented Feb 21, 2025

This PR contains the following updates:

Package Type Update Change
OpenRewrite import minor 3.2.0 -> 3.3.0

Release Notes

openrewrite/rewrite-recipe-bom (OpenRewrite)

v3.3.0: 3.3.0

Compare Source

What's Changed

Full Changelog: https://docs.openrewrite.org/changelog/8-47-1-Release


  • If you want to rebase/retry this PR, check this box

@Picnic-DevPla-Bot
Copy link
Contributor Author

Suggested commit message:

Upgrade OpenRewrite 3.2.0 -> 3.3.0

See:
- https://github.com/openrewrite/rewrite-recipe-bom/releases/tag/v3.3.0
- https://github.com/openrewrite/rewrite-recipe-bom/compare/v3.2.0...v3.3.0

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that this upgrade is incompatible with JDK 23:

Caused by: org.openrewrite.java.JavaParsingException: Failed to convert for the following cursor stack:--- BEGIN PATH ---
JCCompilationUnit(sourceFile = Test.java)
--- END PATH ---

	... 88 more
Caused by: java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.DCTree$DCDocComment com.sun.tools.javac.tree.DocCommentTable.getCommentTree(com.sun.tools.javac.tree.JCTree)'
	at org.openrewrite.java.isolated.ReloadableJava17ParserVisitor.convert(ReloadableJava17ParserVisitor.java:1744)
	... 86 more

I tested JDK 17, 21, 22 and 23 builds locally: only the JDK 23 build fails. CC @timtebeek.

@timtebeek
Copy link
Contributor

Thanks for the headsup! No idea what might have changed there: I didn't spot or do any relevant changes I think. :/
I'm out for the next two weeks though; Perhaps Merlin or Knut could have a look if you're planning a release soon.

@Stephan202
Copy link
Member

I don't think we're planning a release soon, so no rush!

I had a quick look myself; @knutwannheden @MBoegers I'm a bit surprised to see that the BOM diff is empty, but if this recent change is part of the new release, that could explain the issue. 👀

@MBoegers
Copy link

Hi @Stephan202 the empty bom looks strange, at the first glace and thanks for the upfront investigation.

I plan to look into the issue monday morning CEST, if we are blocking any urgent release let me know and I see what can be done over the weekend. Does that work for you?

@Stephan202
Copy link
Member

@MBoegers thanks for the rapid response, but please don't spend your weekend on this; we have no release plans. 🙏 Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants