Skip to content

Conversation

@micahstubbs
Copy link
Contributor

Summary

  • Add lspServers configuration to phpactor plugin entry in marketplace.json

Fixes #15

Root Cause

Claude Code reads LSP configuration from the lspServers field in marketplace.json, not from .lsp.json files in plugin directories.

Test Plan

  • Install/update the phpactor plugin
  • Restart Claude Code session
  • Verify LSP works on .php files

Fixes Piebald-AI#15

Claude Code reads LSP configuration from the lspServers field in
marketplace.json, not from .lsp.json files in plugin directories.
@bl-ue bl-ue closed this Jan 30, 2026
@bl-ue
Copy link
Member

bl-ue commented Jan 30, 2026

@Fkscorpion I see you've reacted to this PR; are you able to help me understand the value of it? I'm not aware of .lsp.json not being used, and no one has really complained about these LSPs not working as they're currently configured. I'm totally fine with fixing them if there's a problem, but I'd like to understand the need first. This PR adds a lspServers field to marketplace.json, but the contents of that lspServers field are already in the phpactor plugin's .lsp.json, so this would result in duplication.

@bl-ue bl-ue reopened this Jan 30, 2026
@Fkscorpion
Copy link

@bl-ue I honestly can't remember why I liked this PR specifically, I know I had some issues setting up the lsp plugin with phpactor but it's running for some time now... so I'm very sorry and thank you for asking before closing!

@bl-ue bl-ue closed this Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

phpactor plugin missing lspServers config in marketplace.json

3 participants