Skip to content

Support for Ubuntu25 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Support for Ubuntu25 #116

merged 2 commits into from
Apr 25, 2025

Conversation

PierreGode
Copy link
Owner

Support for Ubuntu25

@PierreGode
Copy link
Owner Author

AI Pull Request Summary:

Pull Request Analysis for Linux-Active-Directory-join-script

Key Files and Components Modified

The pull request primarily modifies two files:

  1. ADconnection.sh: The main Bash script for connecting to Active Directory.
  2. README.md: The documentation file providing details about the script and its supported OS versions.

Main Purpose of the Changes

The changes in this pull request serve the purpose of:

  • Updating Supported Operating System Versions: The script has been updated to support Ubuntu 25, reflecting the latest operating system compatibility.
  • Documentation Updates: The README file has been modified to align with the script changes regarding supported OS versions.

Specific Functionalities Introduced, Modified, or Removed

  1. In ADconnection.sh:

    • Lines Added:
      • # Supported OS's: Ubuntu 14-25 + mate, ... - This line updates the supported Ubuntu version from 24 to 25.
      • if [ "$var" -eq "25" ] - The conditional checks have been updated to include support for Ubuntu version 25.
    • Lines Removed:
      • # Supported OS's: Ubuntu 14-24 + mate, ... - The previous version support line has been removed.
      • Conditionals that previously checked for Ubuntu versions 19 to 24 have been expanded to include version 25:
        • if [ "$var" -eq "17" ] || ... || [ "$var" -eq "24" ] becomes if [ "$var" -eq "17" ] || ... || [ "$var" -eq "25" ]
        • Similar updates are made to another conditional block.
  2. In README.md:

    • Lines Added:
      • <li>Ubuntu 14-25 + mate</li> - Updated the list of supported OS versions in the documentation.
    • Lines Removed:
      • <li>Ubuntu 14-24 + mate</li> - The prior version support line has been removed to reflect the new versioning.

Potential Implications or Considerations

  • Compatibility: The addition of support for Ubuntu 25 is crucial for users operating on newer systems. Users on older versions (pre-14) might still face compatibility issues if they attempt to run the script without testing for those versions.
  • Documentation Consistency: The changes made in the README ensure that users are correctly informed about the supported operating systems, reducing confusion and potential errors during execution.
  • No Breaking Changes: The modifications do not introduce any breaking changes as they only add support for a newer version of Ubuntu while maintaining existing checks for prior versions.

Summary

The pull request introduces updates to the ADconnection.sh script and the README.md file, primarily to extend support to Ubuntu 25. The changes ensure that the documentation aligns with the script's functionalities, which now includes checks for version 25 in its compatibility logic. There are no breaking changes introduced, and the modifications enhance the script's usability for users operating on the latest Ubuntu systems.

@PierreGode PierreGode merged commit 1186001 into master Apr 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant