-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat(sdk): add configuredProps arg to updateTrigger method #16490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe changes introduce version 1.6.0 of the SDK, updating both the changelog and package metadata. The main functional update is the extension of the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/sdk/CHANGELOG.md (3)
7-10
: Enhance “Added” entry clarity
The “Added” subsection correctly highlights the newconfiguredProps
argument forupdateTrigger
. To improve traceability, consider appending the PR number or issue link (e.g.(#16490)
) so consumers can quickly locate the implementation details.
13-13
: Specify original and new return types
The bullet “Corrected the return type ofupdateTrigger
” is concise but could be more informative. You might list the previous type (V1DeployedComponent
) and the new type (GetTriggerResponse
) to give readers immediate context.
14-15
: Grammar: pluralize “type” to “types”
In “Changed the type of property values ofConfigureComponentContext
…”, pluralizingtype
totypes
better reflects that multiple property-value types are affected.🧰 Tools
🪛 LanguageTool
[grammar] ~14-~14: In this context, ‘type’ should agree in number with the noun after ‘of’.
Context: ... type ofupdateTrigger
. - Changed the type of property values ofConfigureComponentContext
from e...(TYPE_OF_PLURAL)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/sdk/CHANGELOG.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
packages/sdk/CHANGELOG.md
[grammar] ~14-~14: In this context, ‘type’ should agree in number with the noun after ‘of’.
Context: ... type of updateTrigger
. - Changed the type of property values of ConfigureComponentContext
from e...
(TYPE_OF_PLURAL)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Lint Code Base
- GitHub Check: test
- GitHub Check: pnpm publish
🔇 Additional comments (1)
packages/sdk/CHANGELOG.md (1)
5-6
: Confirm version bump and date
The new section for1.6.0
dated2025-04-30
aligns with the package.json bump. Verify that this release date matches your CI/CD tag or GitHub release for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WHY
The API now supports updating a deployed trigger's configured props.
Summary by CodeRabbit
Documentation
New Features
Refactor