-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Gmail 'Create Draft' improvement #16536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
""" WalkthroughThe changes introduce enhancements to the Gmail "Create Draft" action by adding two new properties: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CreateDraftAction
participant GmailApp
User->>CreateDraftAction: Provide draft details, fromEmail, signature
CreateDraftAction->>GmailApp: Call getOptionsToSendEmail with props
alt signature provided & HTML body
GmailApp->>GmailApp: Append signature to HTML body
end
GmailApp-->>CreateDraftAction: Return email options
CreateDraftAction-->>User: Draft created with sender and signature
Assessment against linked issues
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/gmail/gmail.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ing to Get Time Entries action (PipedreamHQ#16536)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #15556
Note: only signatures that are explicitly set as the sender email's signature can be selected (those that are not, are not returned by Gmail's API, but a custom value can still be used)
Regarding PR checks, only updating the version of 1 component since no others use the signature property which was added in the app file's method.
Summary by CodeRabbit
New Features
Improvements
Chores