Accommodating the old "jump" action#18
Draft
tntscreed wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine refers to animated character actions like "fall", "fall_land" an "fall_water" - these do not exist in PotC character animation files. These new actions are used by the newer game(s).
The animation that is referred to in the engine as "fall" is defined as "jump" by PotC. (I believe "jump" might refer to another action in the newer games.)
Also, the newer game(s) seem(s) to have separate actions for falling, landing in water, and landing on land.
This inconsistency results in strange behaviour in Beyond New Horizons when falling.
To showcase this, in this PR I have some code that calls the "jump" action instead of "fall", and therefore falling from larger heights works as expected (falling from smaller heights is still strange). However, this likely breaks the same functionality of the newer game(s). Additional changes are required to accommodate both systems.