[#29]: Compat audit for Codex v0.129.0 item/fileChange and outputDelta removal#37
Merged
Conversation
…n v0.129.0 Codex v0.129.0 (PR #20471) removed item/fileChange and outputDelta notification events from the app-server event stream. Audit finding: codex-trace is unaffected because it reads JSONL session files from disk via filesystem watchers — it never connects to the Codex app-server event stream. Neither item/fileChange nor outputDelta appear anywhere in the codebase; the turn parser's wildcard arm already drops unknown event_msg types gracefully. Add an explicit regression test in turn.rs that: - Verifies item/fileChange and outputDelta event_msg entries are silently ignored - Confirms turns still complete normally when these events are present in a JSONL file - Documents the architectural reason (disk-based JSONL reading, not app-server subscription) Fixes #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit and compatibility fix for Codex v0.129.0 (PR #20471), which removed
item/fileChangeandoutputDeltanotification events from the app-server event stream.Audit Finding
codex-trace is unaffected by this change. The tool reads JSONL session files from disk (
~/.codex/sessions/YYYY/MM/DD/rollout-*.jsonl) via filesystem watchers — it never connects to the Codex app-server event stream. Neitheritem/fileChangenoroutputDeltaare referenced anywhere in the codebase.Even if these event types appeared as
event_msgentries in older JSONL session files, they would be silently dropped by the existing wildcard arm inhandle_event_msg. File-change data is already read frompatch_apply_endevents viapatch_changes— no dependency on the removed notification types exists.Changes
src-tauri/src/parser/turn.rs: Added regression testv0129_removed_item_file_change_and_output_delta_events_ignored_gracefullythat:item/fileChangeandoutputDeltaevent_msgentries are silently ignoredTesting
All existing tests continue to pass (60 Rust unit tests, 122 frontend tests). The new test explicitly exercises the v0.129.0 compat scenario.
Fixes #29