[#36]: Compat audit for Codex v0.130.0 startup banner research preview removal#40
Merged
Conversation
…v0.130.0 Codex v0.130.0 (PR #21683) removed the "research preview" wording from the `codex exec` startup banner. codex-trace never pattern-matched that text — version detection reads `cli_version` from structured JSONL session_meta entries, and exec output parsing uses stable structural markers (Output:, exit code, wall time, session id). Add two regression-guard tests to make this explicit: - entry.rs: v0.130.0 session files parse all standard entry types correctly - toolcall.rs: exec output with and without the old banner text produces identical parsed status, exit code, duration, and payload Fixes #36
Codex v0.130.0 (PR #21683) removed "research preview" from the codex exec startup banner. codex-trace is unaffected: version detection reads cli_version from session_meta.payload.cli_version — a structured JSONL field — never from banner text output. No code change is required. Adds a regression test that explicitly verifies a v0.130.0 session_meta entry parses correctly and that cli_version is read from structured JSON, documenting the architectural boundary (JSONL file reader, not CLI runner).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36
Audit and compatibility fix for Codex v0.130.0 (PR #21683), which removed the "research preview" wording from the
codex execstartup banner.Audit Finding
codex-trace is unaffected by this change. The tool reads JSONL session files from disk (
~/.codex/sessions/YYYY/MM/DD/rollout-*.jsonl) — it never parsescodex execbanner output. Version detection usessession_meta.payload.cli_version, a structured JSON field written into every session file, not any text from the startup banner.No production code change is required.
Changes
src-tauri/src/parser/entry.rs: Added two regression tests:v0130_startup_banner_research_preview_removal_does_not_affect_version_detection— verifies a v0.130.0session_metaentry parses correctly andcli_versionis read from the structured JSON fieldcodex_v0_130_0_startup_banner_change_does_not_affect_session_parsing— end-to-end: all standard entry types from a v0.130.0 session parse without error, documenting the architectural boundary (disk-based JSONL reader, not CLI banner parser)src-tauri/src/parser/toolcall.rs: Added regression test:exec_output_parsing_unaffected_by_codex_v0_130_0_banner_change— verifiesparse_exec_function_outputproduces identical results for old and new banner formats, confirming that only stable structural markers (Output:,Exit code:,Wall time:) are used, not banner wordingTesting