Moved root menu and toggle button to top right of window#8
Open
crschmidt2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains the changes to move the ToggleMenuButton and RootMenu in line with the buttons in the top right of steam, such as the notifications and news buttons.
I think it makes more sense for a settings button to be in the top right if it's not going to be its own bar, but if that doesn't fit the theme that others would want I could try to make it a toggle-able switch in the theme configuration.
There are still a few tweaks to be made:
Other than that I'm happy with it. I also think it would be a good idea to get this change in now since I don't know when I can work on it some more, and someone else could take time to fix the things above. Thank you!