Skip to content

pgconn: apply a 10-second connection timeout everywhere #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brmzkw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pgconn: apply a 10-second connection timeout everywhere #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pgconn/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ import (
_ "github.com/jackc/pgx/v5/stdlib"
)

// defaultConnectTimeout is the number of seconds allowed for the initial TCP
// connection and authentication to complete. It is applied uniformly to all
// Go-side connections (via the DSN) and to all subprocess connections (via
// PGCONNECT_TIMEOUT), so that a packet-dropping firewall is detected quickly
// rather than hanging indefinitely.
const defaultConnectTimeout = 10

// sslFileParam describes one SSL file parameter and its inline-content variant.
type sslFileParam struct {
pathKey string // config key for the file path, e.g. "ssl_cert"
Expand Down Expand Up @@ -167,6 +174,7 @@ func (c ConnConfig) Env() []string {
if c.SSLRootCert != "" {
env = append(env, "PGSSLROOTCERT="+c.SSLRootCert)
}
env = append(env, fmt.Sprintf("PGCONNECT_TIMEOUT=%d", defaultConnectTimeout))
return env
}

Expand All @@ -185,6 +193,7 @@ func (c ConnConfig) DSN(dbname string) string {
}
}
q := url.Values{}
q.Set("connect_timeout", fmt.Sprintf("%d", defaultConnectTimeout))
if c.SSLMode != "" {
q.Set("sslmode", c.SSLMode)
}
Expand Down
Loading