Conversation
The s3 storage ideally only needs to do stdio and open sockets. Since there's TLS in the mix we also need the golang stdlib to access the right cert.pem. Here the thing gets a little bit more complicated. The stdlib tries to open cert.pem at "well-known" locations, including paths that don't make sense on OpenBSD (e.g. /usr/local/etc/ssl/cert.pem). To prevent that, set SSL_CERT_FILE to /etc/ssl/cert.pem, but only if it's not already set, and unveil that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The s3 storage ideally only needs to do stdio and open sockets. Since there's TLS in the mix we also need the golang stdlib to access the right cert.pem.
Here the thing gets a little bit more complicated. The stdlib tries to open cert.pem at "well-known" locations, including paths that don't make sense on OpenBSD (e.g. /usr/local/etc/ssl/cert.pem).
To prevent that, set SSL_CERT_FILE to /etc/ssl/cert.pem, but only if it's not already set, and unveil that path.
This is just to give an idea. If we like it I can do the same for the importer and exporter. (in this precise moment I don't have a good setup for an s3 importer, that's why it's not in the diff.)