ci: also ignore top-level testing/*.go files in Codecov#440
Merged
Conversation
The previous "testing/**/*" pattern matched testing/state/foo.go and testing/fileinfo/foo.go but NOT testing/backend.go and friends — Codecov's glob requires "testing/*" for files directly in the testing/ directory. This left 8 helper files in the report, dragging the project total down and showing testing/ as a 0%-coverage row in the dashboard. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous `testing/**/*` glob matched files in subdirectories (`testing/state/foo.go`, `testing/fileinfo/foo.go`) but not files directly inside `testing/` (`testing/backend.go`, `testing/repository.go`, etc.).
Codecov's API confirms 8 testing helper files are still in the report:
```
testing/backend.go
testing/classifier.go
testing/context.go
testing/exporter.go
testing/importer.go
testing/repository.go
testing/snapshot.go
testing/storage.go
```
These all sit at 0% local coverage (they're driven by tests in other packages with their own `_test.go` files) and drag the project number down.
Adds `"testing/"` alongside `"testing/**/"` so both the directory and its immediate children are excluded.
Test plan
🤖 Generated with Claude Code