PoolpOrg/add missing header fields#442
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
omar-polo
left a comment
There was a problem hiding this comment.
no objections from me.
this does not break backward compatibility because it's an addition: the fields gets message-pack serialized / deserialized, and if empty IIRC it's skipped. in addition: older version of kloset will ignore new fields, keeping them operational.
mathieu-plak
left a comment
There was a problem hiding this comment.
Wondering why that first commit is part of this PR, otherwise LGTM, as op@ said no breakage anticipated here!
|
erf, that commit is me forgetting to switch branch. I'll commit it separately as it's ci and rebase this one |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dataset header field allows providing a generic dataset identifier to identify a snapshot, could be a sourceId in control plane, the UUID of a specific dataset in a different system, generic field that can be used specifically by different wrapping applications.
data classes header field allows attaching ... data classes to a snapshot, this is different from category (ie; category=system, data_classes=["finance", "health"], ...)
This is in the blocking path of control plane, please review and approve timely