Skip to content

PoolpOrg/add missing header fields#442

Merged
poolpOrg merged 2 commits into
mainfrom
poolpOrg/add-missing-header-fields
May 27, 2026
Merged

PoolpOrg/add missing header fields#442
poolpOrg merged 2 commits into
mainfrom
poolpOrg/add-missing-header-fields

Conversation

@poolpOrg
Copy link
Copy Markdown
Contributor

dataset header field allows providing a generic dataset identifier to identify a snapshot, could be a sourceId in control plane, the UUID of a specific dataset in a different system, generic field that can be used specifically by different wrapping applications.

data classes header field allows attaching ... data classes to a snapshot, this is different from category (ie; category=system, data_classes=["finance", "health"], ...)

This is in the blocking path of control plane, please review and approve timely

poolpOrg and others added 2 commits May 27, 2026 16:43
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

@omar-polo omar-polo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections from me.

this does not break backward compatibility because it's an addition: the fields gets message-pack serialized / deserialized, and if empty IIRC it's skipped. in addition: older version of kloset will ignore new fields, keeping them operational.

Copy link
Copy Markdown
Contributor

@mathieu-plak mathieu-plak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why that first commit is part of this PR, otherwise LGTM, as op@ said no breakage anticipated here!

@poolpOrg
Copy link
Copy Markdown
Contributor Author

erf, that commit is me forgetting to switch branch.

I'll commit it separately as it's ci and rebase this one

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@poolpOrg poolpOrg merged commit 9bfac39 into main May 27, 2026
7 checks passed
@poolpOrg poolpOrg deleted the poolpOrg/add-missing-header-fields branch May 27, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants