state: Harden all *FromBytes routine#447
Merged
Merged
Conversation
* Next() doesn't really do what I thought it did and we can actually have short reads on those and panic later on when trying to interpret that buffer as an integer. * To fix this for now before a biffer refactor, let's just guard all this function with a size check!
mathieu-plak
force-pushed
the
mm/harden_state_entries_parsing
branch
from
43fcd8e to
8fd74c8
Compare
omar-polo
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next() doesn't really do what I thought it did and we can actually have short reads on those and panic later on when trying to interpret that buffer as an integer.
To fix this for now before a biffer refactor, let's just guard all this function with a size check!