backup: Move all Snapshot creation fields out of kcontext.#45
Closed
mathieu-plak wants to merge 1 commit into
Closed
backup: Move all Snapshot creation fields out of kcontext.#45mathieu-plak wants to merge 1 commit into
mathieu-plak wants to merge 1 commit into
Conversation
* Removes everything used only in snapshot creation (backup/sync/ptar) etc to a dedicated BuilderOptions type like we do elsewhere. * This is the easy part of the diff, plakar is another beast and will come soon after. * Note that apart from snap header the Hostname is also used by Locks() (as an hint to the user), we tap into the Header to retrieve this info as a fallback, since Locks needs to go away anyway. * Note2: I'm getting rid of kcontext_test.go, sorry sayoun@ but kcontext is meant to die and the tests are just introducing churn for the sake of churn in this particular instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes everything used only in snapshot creation (backup/sync/ptar) etc to a dedicated BuilderOptions type like we do elsewhere.
This is the easy part of the diff, plakar is another beast and will come soon after.
Note that apart from snap header the Hostname is also used by Locks() (as an hint to the user), we tap into the Header to retrieve this info as a fallback, since Locks needs to go away anyway.
Note2: I'm getting rid of kcontext_test.go, sorry sayoun@ but kcontext is meant to die and the tests are just introducing churn for the sake of churn in this particular instance.
Keeping as WIP though it's not, because I don't want this to be merged accidentally.