prune: honor -group-by; docs: document the flag#2162
Merged
Conversation
3 tasks
omar-polo
approved these changes
May 29, 2026
mathieu-plak
approved these changes
May 29, 2026
poolpOrg
force-pushed
the
feature/locate-group-by
branch
from
5117c2a to
119abfe
Compare
mergePolicyOptions overwrites Filters but used to drop GroupBy on the floor, so -group-by parsed from the command line never reached Match. Document -group-by in plakar-query(7). Requires the GroupBy field on locate.LocateOptions (PlakarKorp/kloset#441). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
poolpOrg
force-pushed
the
feature/locate-group-by
branch
from
119abfe to
a7de218
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergePolicyOptionsoverwritesFiltersbut used to dropGroupByon the floor, so-group-byparsed from the command line never reachedMatch. Three lines fix it.plakar-query(7)gets a new entry for the flag; every subcommand that supports the locate flags (ls,prune,locate,check,mount,rm,sync,config policy) already defers to it.Requires the
GroupByfield onlocate.LocateOptions— PlakarKorp/kloset#441.Test plan
plakar at /tmp/repo prune -perimeter foo -tag bar -days 1 -per-day 1 -group-by namekeeps the newest snapshot per name; without-group-byit keeps the newest overall-applyremoves the expected set