Skip to content

Swarm Fix: [BUG] [v1.1.0] About Cortex Desktop (SystemSpecs): labels and secondary text use Tailwind text-neutral-* / text-red-400 instead of Cortex text/error tokens#37649

Open
hinzwilliam52-ship-it wants to merge 1 commit intoPlatformNetwork:mainfrom
hinzwilliam52-ship-it:fix-bug-v1-1-0-about-cortex-desktop-systemsp-1774405421
Open

Swarm Fix: [BUG] [v1.1.0] About Cortex Desktop (SystemSpecs): labels and secondary text use Tailwind text-neutral-* / text-red-400 instead of Cortex text/error tokens#37649
hinzwilliam52-ship-it wants to merge 1 commit intoPlatformNetwork:mainfrom
hinzwilliam52-ship-it:fix-bug-v1-1-0-about-cortex-desktop-systemsp-1774405421

Conversation

@hinzwilliam52-ship-it
Copy link

@hinzwilliam52-ship-it hinzwilliam52-ship-it commented Mar 25, 2026

Description

Brief description of the changes in this PR.

Related Issue

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Code refactoring

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Testing

Describe the tests you ran to verify your changes.

# Example commands
cargo test
cargo clippy

Screenshots (if applicable)

Add screenshots to help explain your changes.

Summary by CodeRabbit

  • Documentation
    • Added internal development documentation outlining styling updates.

…s and secondary text use tailwind text-neutral-* / text-red-400 instead of cortex text/error tokens

Signed-off-by: hinzwilliam52-ship-it <hinzwilliam52@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

📝 Walkthrough

Walkthrough

A new FIX_PROPOSAL.md document is added containing instructions to refactor SystemSpecs.tsx by replacing Tailwind palette class names with Cortex text token classes or CSS variable-based alternatives, including before/after examples.

Changes

Cohort / File(s) Summary
Documentation
FIX_PROPOSAL.md
New proposal document with explicit instructions and examples for updating SystemSpecs.tsx to use Cortex text token classes instead of Tailwind palette classes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A proposal hops into sight,
With tokens shining oh so bright,
Cortex colors, CSS wise,
Tailwind fades before our eyes,
Refactoring made crystal clear!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: it identifies a specific bug in SystemSpecs component where Tailwind text classes are incorrectly used instead of Cortex design tokens, and the PR adds a FIX_PROPOSAL.md document addressing this issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
FIX_PROPOSAL.md (1)

25-48: Consider making the examples more context-specific.

The before/after examples use generic <div> elements with placeholder text. If possible, include examples that more closely match the actual structure of the SystemSpecs component (e.g., specific labels, system information displays, error states) to make the fix proposal more actionable.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@FIX_PROPOSAL.md` around lines 25 - 48, Update the examples in FIX_PROPOSAL.md
to use SystemSpecs-specific markup and labels instead of generic <div>
placeholders so the change is actionable; e.g., show the actual fields from the
SystemSpecs component (like "CPU", "Memory", "Status", "Error message") and
demonstrate replacing className values such as "text-neutral-400",
"text-neutral-500", "text-red-400" with the new tokens "text-secondary",
"text-inactive", "text-error" or with style vars like
"var(--cortex-text-secondary)", "var(--cortex-text-inactive)",
"var(--cortex-error)"; make sure the examples reference the SystemSpecs
component context (e.g., the status label and an inline error message) so
reviewers can see the exact before/after for SystemSpecs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@FIX_PROPOSAL.md`:
- Around line 25-48: Update the examples in FIX_PROPOSAL.md to use
SystemSpecs-specific markup and labels instead of generic <div> placeholders so
the change is actionable; e.g., show the actual fields from the SystemSpecs
component (like "CPU", "Memory", "Status", "Error message") and demonstrate
replacing className values such as "text-neutral-400", "text-neutral-500",
"text-red-400" with the new tokens "text-secondary", "text-inactive",
"text-error" or with style vars like "var(--cortex-text-secondary)",
"var(--cortex-text-inactive)", "var(--cortex-error)"; make sure the examples
reference the SystemSpecs component context (e.g., the status label and an
inline error message) so reviewers can see the exact before/after for
SystemSpecs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5b2e0307-f53f-46c6-9c93-2664ccee4c19

📥 Commits

Reviewing files that changed from the base of the PR and between ec21e1b and 93cdc20.

📒 Files selected for processing (1)
  • FIX_PROPOSAL.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant