Swarm Fix: [BUG] [v1.1.0] About Cortex Desktop (SystemSpecs): labels and secondary text use Tailwind text-neutral-* / text-red-400 instead of Cortex text/error tokens#37649
Conversation
…s and secondary text use tailwind text-neutral-* / text-red-400 instead of cortex text/error tokens Signed-off-by: hinzwilliam52-ship-it <hinzwilliam52@gmail.com>
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
FIX_PROPOSAL.md (1)
25-48: Consider making the examples more context-specific.The before/after examples use generic
<div>elements with placeholder text. If possible, include examples that more closely match the actual structure of the SystemSpecs component (e.g., specific labels, system information displays, error states) to make the fix proposal more actionable.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@FIX_PROPOSAL.md` around lines 25 - 48, Update the examples in FIX_PROPOSAL.md to use SystemSpecs-specific markup and labels instead of generic <div> placeholders so the change is actionable; e.g., show the actual fields from the SystemSpecs component (like "CPU", "Memory", "Status", "Error message") and demonstrate replacing className values such as "text-neutral-400", "text-neutral-500", "text-red-400" with the new tokens "text-secondary", "text-inactive", "text-error" or with style vars like "var(--cortex-text-secondary)", "var(--cortex-text-inactive)", "var(--cortex-error)"; make sure the examples reference the SystemSpecs component context (e.g., the status label and an inline error message) so reviewers can see the exact before/after for SystemSpecs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@FIX_PROPOSAL.md`:
- Around line 25-48: Update the examples in FIX_PROPOSAL.md to use
SystemSpecs-specific markup and labels instead of generic <div> placeholders so
the change is actionable; e.g., show the actual fields from the SystemSpecs
component (like "CPU", "Memory", "Status", "Error message") and demonstrate
replacing className values such as "text-neutral-400", "text-neutral-500",
"text-red-400" with the new tokens "text-secondary", "text-inactive",
"text-error" or with style vars like "var(--cortex-text-secondary)",
"var(--cortex-text-inactive)", "var(--cortex-error)"; make sure the examples
reference the SystemSpecs component context (e.g., the status label and an
inline error message) so reviewers can see the exact before/after for
SystemSpecs.
Description
Brief description of the changes in this PR.
Related Issue
Fixes #(issue number)
Type of Change
Checklist
Testing
Describe the tests you ran to verify your changes.
Screenshots (if applicable)
Add screenshots to help explain your changes.
Summary by CodeRabbit