Skip to content

Swarm Fix: [BUG] [alpha] Split panel shortcut displays shifted character (") instead of base key, causing ambiguity #38323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willkhinz wants to merge 1 commit into
base: main
Choose a base branch
from
+52 −0
Open

Swarm Fix: [BUG] [alpha] Split panel shortcut displays shifted character (") instead of base key, causing ambiguity #38323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions FIX_PROPOSAL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
To resolve the issue of the shortcut for "Split Down" displaying as Ctrl + Shift + " instead of the base key, we need to adjust the way the shortcut is displayed to reflect the actual key pressed, which is typically the apostrophe (') key when shifted.

Given the context, the solution involves modifying the code that generates or displays the shortcut for "Split Down" in the application. Since the exact codebase or programming language isn't specified, I'll provide a general approach that can be adapted to various environments.

### Solution Approach

1. **Identify the Code**: Locate the part of the code that generates or displays the shortcut for "Split Down". This could be in a configuration file, a string resource, or directly in the code that handles keyboard shortcuts.

2. **Modify the Shortcut Display**: Change the display of the shortcut from Ctrl + Shift + " to Ctrl + Shift + '. This ensures that the shortcut is represented by the base key that, when shifted, results in the desired character.

3. **Ensure Consistency Across Keyboard Layouts**: To maintain consistency across different keyboard layouts, ensure that the application can dynamically detect and adjust the shortcut display based on the user's keyboard layout. This might involve using operating system APIs to determine the current keyboard layout and adjusting the shortcut display accordingly.

### Example Code (JavaScript)

If we were working in a JavaScript environment, the modification might look something like this:

```javascript
// Before
const splitDownShortcut = "Ctrl + Shift + \"";

// After
const splitDownShortcut = "Ctrl + Shift + '";
```

For a more dynamic approach that considers the keyboard layout:

```javascript
function getSplitDownShortcut() {
// Assuming a function to get the current keyboard layout
const keyboardLayout = getKeyboardLayout();

// Adjust the shortcut display based on the keyboard layout
if (keyboardLayout === "US") {
return "Ctrl + Shift + '";
} else {
// Handle other layouts as needed
return "Ctrl + Shift + \"";
}
}
Comment on lines +27 to +39
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Questionable fallback logic in keyboard layout handling.

The dynamic example returns Ctrl + Shift + " for non-US keyboard layouts (line 37), which contradicts the stated goal of displaying the base key instead of the shifted character. If the intent is to show the base key that produces the desired character when shifted, all keyboard layouts should display the unshifted key.

Consider either:

  1. Removing the else clause and consistently showing the base key across all layouts
  2. Providing a more comprehensive mapping that identifies the correct base key for each layout
  3. Clarifying the intent if different layouts genuinely require different representations
💡 Proposed fix for consistent base key display 
 function getSplitDownShortcut() {
     // Assuming a function to get the current keyboard layout
     const keyboardLayout = getKeyboardLayout();
     
-    // Adjust the shortcut display based on the keyboard layout
-    if (keyboardLayout === "US") {
-        return "Ctrl + Shift + '";
-    } else {
-        // Handle other layouts as needed
-        return "Ctrl + Shift + \"";
-    }
+    // Map keyboard layouts to their base key for apostrophe/quote
+    const baseKeyMap = {
+        "US": "'",
+        // Add other layouts as needed, mapping to their base key
+        // that produces the intended character when shifted
+    };
+    
+    const baseKey = baseKeyMap[keyboardLayout] || "'";
+    return `Ctrl + Shift + ${baseKey}`;
 }
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@FIX_PROPOSAL.md` around lines 27 - 39, The fallback logic in
getSplitDownShortcut returns a shifted character for non-US layouts; instead
ensure the function always displays the base (unshifted) key unless a specific
layout mapping exists: update getSplitDownShortcut to consult a
layout-to-base-key map (using getKeyboardLayout()) and return the mapped
unshifted key (e.g., "Ctrl + Shift + '") as the default, removing the current
else that returns the shifted quote character; alternatively, implement/extend a
comprehensive mapping for known layouts and fall back to the consistent base-key
string when no mapping is found.


// Usage
const splitDownShortcut = getSplitDownShortcut();
```

### Commit Message

```
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add language specifier to fenced code block.

The commit message code block should specify a language identifier for better rendering and compliance with markdown best practices. Consider using text or commit as the language identifier.

📝 Proposed fix 
-```
+```text
 Fix: Display base key for Split Down shortcut
 
 * Modify the display of the Split Down shortcut to show the base key (Ctrl + Shift + ') instead of the shifted character.

As per static analysis hints: markdownlint-cli2 flags "Fenced code blocks should have a language specified (MD040)".

🧰 Tools
🪛 markdownlint-cli2 (0.22.0)

[warning] 47-47: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@FIX_PROPOSAL.md` at line 47, The fenced code block containing the commit
message ("Fix: Display base key for Split Down shortcut" and the bullet text)
lacks a language specifier; update its opening fence to include a language token
such as text or commit (e.g., ```text) so the block follows MD040 and renders
correctly.

Fix: Display base key for Split Down shortcut

* Modify the display of the Split Down shortcut to show the base key (Ctrl + Shift + ') instead of the shifted character.
* Ensure consistency across different keyboard layouts by dynamically adjusting the shortcut display.
```