Fixed p1_display reset timing plot crash.#360
Merged
adamshapiro0 merged 2 commits intomasterfrom Mar 24, 2025
Merged
Conversation
If keep_messages is False but return_message_index is True, we do not want to delete the index.
adamshapiro0
force-pushed
the
message-bytes
branch
from
349797c to
d9ee83b
Compare
This is consistent with message_index.
adamshapiro0
force-pushed
the
message-bytes
branch
from
d9ee83b to
f7381c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
MessageData.messages_byteslist tomessage_bytesto matchmessage_indexlistFixes
message_indexlist during numpy conversion ifreturn_message_index=True