Fixed NamedTupleAdapter crash when handling translated values, added optional WebSocket support.
#376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It the input to NamedTupleAdapter is not a construct Containers object, but is something that has already been transformed from a Containers object (e.g., using AutoEnum to transform a Containers result to an enum), we need to use it directly as input to the NamedTuple. It will not have a values() function.
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional WebSocket transport support and fixes several bugs related to message parsing and transport handling. The changes enable WebSocket connections for the Fusion Engine client while maintaining backward compatibility for installations without the websockets library.
- Added WebSocket transport support with
ws://protocol handling and optional dependency management - Fixed
NamedTupleAdaptercrash when processing already-translated enum values - Modified error handling in
FusionEngineDecoderto return raw bytes instead of raising exceptions on parsing failures
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
python/fusion_engine_client/utils/transport_utils.py |
Adds WebSocket transport support, improves serial port regex parsing, and reorganizes optional dependency handling |
python/fusion_engine_client/utils/construct_utils.py |
Fixes NamedTupleAdapter._decode() to handle both Container objects and already-translated values |
python/fusion_engine_client/parsers/decoder.py |
Changes error handling to return raw bytes instead of continuing the parsing loop when message deserialization fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
ws://HOSTNAME:PORTpip install websocketsFixes
NamedTupleAdapterwhen decoding already-translated values like enums (e.g., config response forTransportDirection)bytesobject fromFusionEngineDecoderif the message class has a parsing error instead of raising an exception