update oscc to v1.2.4, add validation modifications#31
Open
update oscc to v1.2.4, add validation modifications#31
Conversation
Prior to this commit, the exponential filter of the inputs (triggers and joystick) were filtered so the modules received a smooth series of commands, but the filters were not cleared after a disable, causing the modules to actuate on old command values when re-enabling. This commit clears the filters when control is not enabled.
Prior to this commit, steering range wasn't being limited from the application firmware whatsoever, i.e. it would iterate through the full allowable range of spoofs. This commit limits it to be 20% of the full range, allowing for better steering control and a better out-of-box user experience.
Prior to this commit, OSCC Joystick Commander didn't have any CI pipeline. This commit adds one.
Prior to this commit, there was an unneeded catch block in the Jenkinsfile. This commit removes it.
Prior to this commit the initialization of the static global variable `joystick_data` was initialized ambiguously and what looked like erroneously. This commit represents a revision explicit initialization instead. Motivation for this change was a support ticket raised with an email to `help@polysync.io` Note to reviewers: I validated that after this change the joystick commander still behaved as _I_ expected on the car but would HIGHLY recommened that reviewers do the same. Thanks!
…into devel * snewt/bug/explicit-joystick-data-init: Make initialization of `joystick_data` explicit
Prior to this commit joystick commander required an ifdef block to support different platforms. This commit updates joystick commander so that the oscc configuration can be referenced instead keeping platform support in the oscc repo.
Prior to this commit joystick commander required the user to clone oscc into the joystick commander directory and did not keep track of oscc versions. This commit fxes that by adding oscc as a submodule so that updates to oscc api and joystick commander can be kept in lockstep.
Update CMake and add Submodule
Before this PR the oscc module was v1.2.3 This PR will make the following changes. oscc default module is now: v1.2.4 Changed the steering range percentage to the value used for validation. `#define STEERING_RANGE_PERCENTAGE (0.36)` Changed commander updat interval so JC will work with the safety gateway `#define COMMANDER_UPDATE_INTERVAL_MICRO (5000)`
I updated the README to follow the the DriveKit README on the `feature/dfu-bootloader` branch. I updated the MIT copyright to 2019 in the license and readme files.
Added note for debug flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR the oscc submodule was v1.2.3
This PR will make the following changes:
oscc default submodule is now: v1.2.4
Changed the steering range percentage to the value used for validation.
#define STEERING_RANGE_PERCENTAGE (0.36)Changed commander update interval so JC will work with the safety gateway
#define COMMANDER_UPDATE_INTERVAL_MICRO (5000)I updated the README to follow the the DriveKit README currently on the
feature/dfu-bootloaderbranch.I updated the MIT copyright to 2019 in the license and readme files.