-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernization - May 2024 #16
base: master
Are you sure you want to change the base?
Changes from 1 commit
ae731a2
7d995ef
d1ff71b
d0ffaa1
fcda3e9
45ea77a
b6b7926
f40c3be
f792408
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# TIMEBOMB: FEWTURE-BOOM1 | ||
# FEWTURE-DO-NOT-REPORT: do not report, it's not within an annotation | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# TIMEBOMB: FEWTURE-BOOM2 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,8 @@ | |
|
||
from check_oldies import annotations | ||
|
||
from . import base | ||
|
||
|
||
FAKE_GIT_BLAME_OUTPUT = """c106813f91ff43b8fc6e231c263bdaa344866157 136 136 1 | ||
some value | ||
|
@@ -65,3 +67,26 @@ def test_get_login_from_committer_email(): | |
assert login == "<@example.com>" # should not be the empty string | ||
login = annotations.get_login_from_committer_email("John Smith") | ||
assert login == "John Smith" | ||
|
||
|
||
|
||
class TestGetKnownFutureTag: | ||
test_data_path = base.TEST_DIR_PATH / "data/project7" | ||
|
||
def test_basics(self): | ||
tags = annotations.get_known_future_tags( | ||
directory=self.test_data_path, | ||
annotation_regex=base.TESTING_ANNOTATIONS[0], | ||
future_tag_regex=base.TESTING_FUTURE_TAG, | ||
whitelist=(), | ||
) | ||
assert tags == {"FEWTURE-BOOM1", "FEWTURE-BOOM2"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Est-ce que le tag n'est pas There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Le tag cherché est bien de type "FUTURE-xxx". "TIMEBOMB", c'est en fait un "FIXME". Peut-être que je devrais le nommer "FIIXME" dans les tests, ce sera plus proche de "FIXME" et donc plus clair. |
||
|
||
def test_whitelist(self): | ||
tags = annotations.get_known_future_tags( | ||
directory=self.test_data_path, | ||
annotation_regex=base.TESTING_ANNOTATIONS[0], | ||
future_tag_regex=base.TESTING_FUTURE_TAG, | ||
whitelist=["file2.py"], | ||
) | ||
assert tags == {"FEWTURE-BOOM1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai bien envie de d'utiliser le terme
FEWTURE
premier degré maintenant 😄