Repository navigation
docs: three suites by position, the rehearsal inside PreUpgrade - #5
Merged
Merged
Conversation
adi-poly
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
polymarket-v2 #369 now runs a release's checks as three suites by position:
PostDeploy,PreUpgrade(the safe-sim-style rehearsal of the release's own plans, before the proposal is filed) andPostUpgrade(every post check, the functional tests included).docs/testing.mdstill described five, with a separateFunctional.t.solstep.Modifications
docs/testing.md: the three suites and what each sees; before / after in the checklist mapped to them; the functional tests placed insidePostUpgrade; "applying a plan yourself" named asPreUpgrade's job.Result
The testing guide and the reference release describe the same shape.
Note
Low Risk
Documentation-only change with no runtime or test code impact.
Overview
Updates
docs/testing.mdso release testing is described as three position-based suites (PostDeploy,PreUpgrade,PostUpgrade) instead of the old before/after-deploy/execute framing and a separateFunctional.t.solverify step.PostDeploy covers staged implementation checks; PreUpgrade is the safe-sim-style rehearsal that applies plans on the fork before proposal; PostUpgrade covers post-governance state plus functional behaviour tests (formerly a standalone step). The checklist’s before / after columns are mapped to those suites, and “applying a plan yourself” is explicitly PreUpgrade’s role.
Reviewed by Cursor Bugbot for commit 2c58761. Bugbot is set up for automated code reviews on this repo. Configure here.