Skip to content

docs: three suites by position, the rehearsal inside PreUpgrade - #5

Merged
0xrajath merged 1 commit into
mainfrom
docs/three-suites
Oct 7, 2026
Merged

0xrajath merged 1 commit into
mainfrom
docs/three-suites

Conversation

@0xrajath

@0xrajath 0xrajath commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

polymarket-v2 #369 now runs a release's checks as three suites by position: PostDeploy, PreUpgrade (the safe-sim-style rehearsal of the release's own plans, before the proposal is filed) and PostUpgrade (every post check, the functional tests included). docs/testing.md still described five, with a separate Functional.t.sol step.

Modifications

  • docs/testing.md: the three suites and what each sees; before / after in the checklist mapped to them; the functional tests placed inside PostUpgrade; "applying a plan yourself" named as PreUpgrade's job.

Result

The testing guide and the reference release describe the same shape.


Note

Low Risk
Documentation-only change with no runtime or test code impact.

Overview
Updates docs/testing.md so release testing is described as three position-based suites (PostDeploy, PreUpgrade, PostUpgrade) instead of the old before/after-deploy/execute framing and a separate Functional.t.sol verify step.

PostDeploy covers staged implementation checks; PreUpgrade is the safe-sim-style rehearsal that applies plans on the fork before proposal; PostUpgrade covers post-governance state plus functional behaviour tests (formerly a standalone step). The checklist’s before / after columns are mapped to those suites, and “applying a plan yourself” is explicitly PreUpgrade’s role.

Reviewed by Cursor Bugbot for commit 2c58761. Bugbot is set up for automated code reviews on this repo. Configure here.

@0xrajath
0xrajath merged commit 3dc98d7 into main Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants