Skip to content

Update clob package version - #73

Open
jfullerton44 wants to merge 2 commits into
Polymarket:mainfrom
jfullerton44:jfullerton/versions
Open

Update clob package version#73
jfullerton44 wants to merge 2 commits into
Polymarket:mainfrom
jfullerton44:jfullerton/versions

Conversation

@jfullerton44

@jfullerton44 jfullerton44 commented Jul 5, 2024

Copy link
Copy Markdown

Overview

Updates the clob package version to fix runtime issue

Description

Updates the clob package version to fix and error when iterating through order responses. The new clob version also fixes an issue where there is a type mismatch when looking up values in a dictionary.

Types of changes

  • Refactor/enhancement
  • Bug fix/behavior correction
  • New feature
  • Breaking change
  • Other, additional

Status

  • Prefix PR title with [WIP] if necessary (changes not yet made).
  • Add tests to cover changes as needed.
  • Update documentation/changelog as needed.
  • Verify all tests run correctly in CI and pass.
  • Ready for review/merge.

@Ragnoraks Ragnoraks left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work!

@acebeakerxyz

acebeakerxyz commented Oct 24, 2024

Copy link
Copy Markdown

Looks like FilterParams was split into OpenOrderParams and TradeParams. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants