docs: note that proxy/deposit wallets are not supported - #89
Open
osr21 wants to merge 1 commit into
Open
Conversation
The README is silent on supported wallet types. Users who created their Polymarket account via the web UI (Magic.link / Privy deposit-wallet flow) repeatedly hit confusing errors because the market maker has no proxy wallet support — it requires a plain EOA private key. Add a prominent note under Requirements so users know before setup. Fixes Polymarket#79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README does not mention what wallet types are supported. Users who created their Polymarket account via the web UI (Magic.link / Privy deposit-wallet flow) repeatedly open issues when the market maker rejects their credentials or behaves unexpectedly — see #79, #28, #27, #86.
The market maker trades directly with an EOA private key. It has no proxy-wallet or deposit-wallet support — there is no
funderAddressorPOLY_1271flow. This is non-obvious to anyone who set up their Polymarket account via the modern web onboarding.Fix
Add a prominent note under the Requirements section so users know before they start setup.
Closes #79.
Note
Low Risk
Documentation-only change with no impact on application logic, security, or deployment.
Overview
Adds a Requirements callout stating the keeper only works with a standard EOA private key, and that Polymarket proxy / deposit wallet accounts (web UI, Magic.link, Privy) are not supported, with a link to issue #79 for background.
No code, config, or runtime behavior changes—documentation only to set expectations before setup.
Reviewed by Cursor Bugbot for commit 7e7861f. Bugbot is set up for automated code reviews on this repo. Configure here.