Adding a custom action to downgrade upgrade api version#161
Adding a custom action to downgrade upgrade api version#161Hannah-PortSwigger merged 7 commits intoPortSwigger:mainfrom
Conversation
Hannah-PortSwigger
left a comment
There was a problem hiding this comment.
Thank you for your Bambda submission!
We've reviewed your code, and have the following improvement suggestions.
Please let us know if you have any questions on the feedback provided.
radinanti
left a comment
There was a problem hiding this comment.
It's way better now :)
Thanks for the improvement <3
|
Hi @radinanti I just wanted to check that you'd pushed your changes, as it looks like there is only your initial commit in this pull request 🙂 |
Replaced URL parsing with baserequest.path()
Changed API version detection from loop to regex
|
Hi @Hannah-PortSwigger |
|
Hi @radinanti Thank you, these changes look good. It looks like the Custom Action README has also been updated - are you able to revert this change? I believe this change must have occurred due to a GitHub action running in the wrong context, so I'll take a look at getting that updated in the meantime. |
|
Hi @Hannah-PortSwigger |
|
Hi @radinanti When submitting Bambdas to this repo, we only accept the I've made a change to the automatic workflows to adjust the behavior on forks. Could you pull in these changes and then revert the README? This should prevent the README from automatically updating again. Please let me know if you have any issues! |
This reverts commit e6efd18.
|
Hi @Hannah-PortSwigger, |
Hannah-PortSwigger
left a comment
There was a problem hiding this comment.
Thank you for your changes!
This looks good 🙂
If there's anything else we can help with, then please let us know.
Bambda Contributions
@authorannotation and suitable descriptionThis custom action detects the API version from the path and upgrades downgrades it. You can change the minimum and maximum version numbers in the code.