Skip to content

refactor(ui): share cross-platform visual semantics - #3649

Open
richardsolomou wants to merge 11 commits into
mainfrom
posthog-code/share-cross-platform-visual-semantics
Open

refactor(ui): share cross-platform visual semantics#3649
richardsolomou wants to merge 11 commits into
mainfrom
posthog-code/share-cross-platform-visual-semantics

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 21, 2026

Copy link
Copy Markdown
Member

Problem

Desktop and mobile duplicate the same application palette, so editor, terminal, confetti, and native rendering can drift. Mobile also maps pull-request lifecycle states independently from the existing core presentation policy.

Changes

Move the application palette and brand colors into @posthog/shared, then consume those tokens from mobile and desktop rendering. Mobile's PR badge now uses the core PR visual policy while retaining its native component and icons.

How did you test this?

  • Monorepo typecheck
  • Shared suite: 738 tests
  • Mobile suite: 501 tests
  • UI suite: 2,351 tests
  • Biome and host-boundary checks

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 54610e6.

Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-policies branch 11 times, most recently from 7195e61 to 01aec6d Compare July 29, 2026 07:58
Base automatically changed from posthog-code/share-cloud-task-policies to main July 29, 2026 09:43
@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

✨ Submitted to Merge by @richardsolomou. It will be added to the merge queue once all branch protection rules pass and there are no merge conflicts with the target branch. See more details here.

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou marked this pull request as ready for review July 29, 2026 13:21
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Merge main into cross-platform visual se..." | Re-trigger Greptile

@charlesvien

Copy link
Copy Markdown
Member

Hey @richardsolomou, we've migrated this repo into the PostHog/posthog monorepo, so this PR needs to be recreated there.

Easiest path: check out the monorepo and run the /porting-code-prs skill with your agent pointed at this PR. It has the migration guide and path remappings baked in so the agent doesn't have to figure them out. You don't strictly need it though, just asking your agent to port the PR works fine too.

Shout if you get stuck.

@charlesvien charlesvien added the stale No recent changes to PR label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale No recent changes to PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants