fix(loops): Reintroduce main loops UI in the spaces view - #3919
Conversation
|
😎 Merged manually by @charlesvien - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
/trunk merge |
Prompt To Fix All With AI### Issue 1
packages/ui/src/features/canvas/components/WebsiteChannelLoops.tsx:66-68
**Current-user errors break ownership tabs**
When the loops request succeeds but the current-user request fails, this view converts the missing user to a null owner ID, causing team-visible loops created by the current user to appear under Team loops instead of My loops. Handle the current-user error as the main Loops view does rather than rendering an incorrect ownership split.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "show ownership tabs on personal space lo..." | Re-trigger Greptile |
|
|
|
/trunk remove |
|
/trunk unmerge |
|
/trunk cancel |
There was a problem hiding this comment.
Frontend-only UI reintroduction (Loops tabs/templates in the spaces view) with no touch on risky territory; the sole reviewer concern (current-user fetch failure mishandling ownership split) is addressed in the diff via the added currentUserError branch and is marked resolved.
- Author wrote 30% of the modified lines and has 16 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 104L, 3F substantive — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (104L, 3F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 5f7dbf3 · reviewed head 245d455 |
New commits pushed (delta classified label_absent) — stamphog approval dismissed; re-review running automatically.
There was a problem hiding this comment.
Contained frontend-only change reusing existing loop-template components in the spaces view; the only substantive review concern (ownership-tab handling) targeted code from an earlier commit that is no longer part of the current diff, so it doesn't apply here.
- Author wrote 62% of the modified lines and has 16 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 38L, 2F substantive — within ceiling |
| tier | ✓ | T1-agent / T1b-small (38L, 2F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 3d18b42 · reviewed head 723a8fa |
Problem
The space-scoped Loops tab lost the templates, the ownership tabs and the wider layout from the main Loops page. Loops without a space attachment were missing from #me entirely.
Changes
Reintroduces the main Loops page pieces into the spaces view: the template grid (seeding the wizard with the space attached), the My loops / Team loops tabs in #me and the matching header copy and width.
How did you test this?
Verified #me and a team space in the running app over CDP. Typecheck, biome and the full @posthog/ui vitest suite pass.
Automatic notifications