Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix(loops): Reintroduce main loops UI in the spaces view - #3919

Merged
charlesvien merged 4 commits into
mainfrom
fix/space-loops-templates
Jul 29, 2026
Merged

fix(loops): Reintroduce main loops UI in the spaces view#3919
charlesvien merged 4 commits into
mainfrom
fix/space-loops-templates

Conversation

@charlesvien

Copy link
Copy Markdown
Member

Problem

The space-scoped Loops tab lost the templates, the ownership tabs and the wider layout from the main Loops page. Loops without a space attachment were missing from #me entirely.

Changes

Reintroduces the main Loops page pieces into the spaces view: the template grid (seeding the wizard with the space attached), the My loops / Team loops tabs in #me and the matching header copy and width.

How did you test this?

Verified #me and a team space in the running app over CDP. Typecheck, biome and the full @posthog/ui vitest suite pass.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

😎 Merged manually by @charlesvien - details.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 723a8fa.

@charlesvien charlesvien added Stamphog This will request an autostamp by stamphog on small changes Create Release This will trigger a new release labels Jul 29, 2026
@charlesvien

Copy link
Copy Markdown
Member Author

/trunk merge

Comment thread packages/ui/src/features/canvas/components/WebsiteChannelLoops.tsx Outdated
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
### Issue 1
packages/ui/src/features/canvas/components/WebsiteChannelLoops.tsx:66-68
**Current-user errors break ownership tabs**

When the loops request succeeds but the current-user request fails, this view converts the missing user to a null owner ID, causing team-visible loops created by the current user to appear under Team loops instead of My loops. Handle the current-user error as the main Loops view does rather than rendering an incorrect ownership split.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "show ownership tabs on personal space lo..." | Re-trigger Greptile

@stamphog

stamphog Bot commented Jul 29, 2026

Copy link
Copy Markdown

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 29, 2026
@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 29, 2026
@charlesvien

Copy link
Copy Markdown
Member Author

/trunk remove

@charlesvien

Copy link
Copy Markdown
Member Author

/trunk unmerge

@charlesvien charlesvien removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 29, 2026
@charlesvien

Copy link
Copy Markdown
Member Author

/trunk cancel

github-actions[bot]
github-actions Bot previously approved these changes Jul 29, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend-only UI reintroduction (Loops tabs/templates in the spaces view) with no touch on risky territory; the sole reviewer concern (current-user fetch failure mishandling ownership split) is addressed in the diff via the added currentUserError branch and is marked resolved.

  • Author wrote 30% of the modified lines and has 16 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 104L, 3F substantive — within ceiling
tier T1-agent / T1c-medium (104L, 3F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 5f7dbf3 · reviewed head 245d455

@stamphog
stamphog Bot dismissed github-actions[bot]’s stale review July 29, 2026 10:00

New commits pushed (delta classified label_absent) — stamphog approval dismissed; re-review running automatically.

@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jul 29, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contained frontend-only change reusing existing loop-template components in the spaces view; the only substantive review concern (ownership-tab handling) targeted code from an earlier commit that is no longer part of the current diff, so it doesn't apply here.

  • Author wrote 62% of the modified lines and has 16 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 38L, 2F substantive — within ceiling
tier T1-agent / T1b-small (38L, 2F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 3d18b42 · reviewed head 723a8fa

@charlesvien
charlesvien merged commit 2b244d6 into main Jul 29, 2026
38 checks passed
@charlesvien
charlesvien deleted the fix/space-loops-templates branch July 29, 2026 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Create Release This will trigger a new release Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant