Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix(inbox): use trusted signal report task creation - #4020

Closed
adboio wants to merge 3 commits into
mainfrom
posthog-code/use-trusted-signal-report-task-api
Closed

fix(inbox): use trusted signal report task creation#4020
adboio wants to merge 3 commits into
mainfrom
posthog-code/use-trusted-signal-report-task-api

Conversation

@adboio

@adboio adboio commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Problem

Inbox Create PR and Discuss currently submit billing-relevant Signal Report attribution through generic task creation. The backend is gaining a dedicated action that assigns this attribution after validating the report.

Changes

  • Route Desktop Create PR and Discuss through the trusted Signal Report task action.
  • Preserve implementation versus discussion relationships across desktop and mobile.
  • Add a 404-only fallback so this client can deploy before the backend action.

Why

Signal-funded work must be distinguishable from ordinary Desktop work without trusting a client-selected task origin.

How did you test this?

  • Built workspace dependencies successfully.
  • Core test suite: 2,814 tests passed.
  • Core, API client, and UI typechecks passed.
  • Mobile typechecking remains blocked by unrelated existing errors; none referenced the changed files.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

adboio added 2 commits July 30, 2026 15:26
Generated-By: PostHog Code
Task-Id: bcdaa94d-50a3-4545-bed0-be691f80bb68
Generated-By: PostHog Code
Task-Id: bcdaa94d-50a3-4545-bed0-be691f80bb68
@trunk-io

trunk-io Bot commented Jul 30, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit d788394.

@posthog

posthog Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

Generated-By: PostHog Code
Task-Id: bcdaa94d-50a3-4545-bed0-be691f80bb68
@adboio adboio closed this Jul 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant