This repository was archived by the owner on Aug 6, 2026. It is now read-only.
trunk-merge/pr-4017/c0097244-5dd1-4e96-878c-2e997dad3751 - #4021
Closed
trunk-io[bot] wants to merge 4 commits into
Closed
trunk-merge/pr-4017/c0097244-5dd1-4e96-878c-2e997dad3751#4021trunk-io[bot] wants to merge 4 commits into
trunk-io[bot] wants to merge 4 commits into
Conversation
…navigates Clicking the Activity bell navigates to the Activity page, but quill's popover trigger runs its own open handler after ours and still inside the same click, so `isActivity` is false and the card stores itself as open. The Activity page only hid that state instead of clearing it, so the card reappeared over the next page opened from the feed. Swallow the open belonging to the navigating click, the same way the sidebar's Activity row already does. Generated-By: PostHog Code Task-Id: f89ba875-c0c8-4a08-b088-67b2a900e66d
The first pass swallowed the open that quill's trigger applies on click, which stopped the stray card but left the underlying problem: refusing an open desyncs the trigger. Base UI applies the open internally before we see it, so handing back `false` leaves the bell stuck with `data-popup-open`/`data-pressed` and its hover-open dead until the trigger remounts. The old `!isActivity` gate refused opens the same way, so this was reachable on the Activity page too. Remove the refusals instead: the trigger's own click-open is prevented outright with `preventBaseUIHandler`, and the Activity page renders the bell with no popover at all. Owning the open state in a component that only mounts off the Activity page means it is born closed on every visit, so there is nothing to mask and nothing left over to resurface. Generated-By: PostHog Code Task-Id: f89ba875-c0c8-4a08-b088-67b2a900e66d
Generated-By: PostHog Code Task-Id: f89ba875-c0c8-4a08-b088-67b2a900e66d
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
trunk-io
Bot
deleted the
trunk-merge/pr-4017/c0097244-5dd1-4e96-878c-2e997dad3751
branch
July 30, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 56d86a51b754f750e252335e1525751a6566ce07.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 4017.