test(node): cover server identify and alias delivery in v2 adapter - #5070
dustinbyrne wants to merge 1 commit into
Conversation
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
|
The PR appears safe to merge; no actionable correctness, security, or repository-rule violations were identified. Reviews (1) · Last reviewed commit: "test(node): bind identify and alias for ..." |
Node SDK compliance v2Commit: c3e10f4 Capture v0✅ 55 passed / ❌ 1 non-passing / Drill-down: run artifacts → ❌ migration:yaml-parity-v1:feature_flags:disable_geoip_omitted_defaults_to_false — failed_assertionFlags field differs Code: Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:143 the first flags request field "geoip_disable" should equal JSON false Operation: Field: Expected: false Actual value: true Harness exit: 1; report validation exit: 1. Capture v1✅ 120 passed / ❌ 1 non-passing / Drill-down: run artifacts → ❌ migration:yaml-parity-v1:feature_flags:disable_geoip_omitted_defaults_to_false — failed_assertionFlags field differs Code: Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:143 the first flags request field "geoip_disable" should equal JSON false Operation: Field: Expected: false Actual value: true Harness exit: 1; report validation exit: 1. |
marandaneto
left a comment
There was a problem hiding this comment.
The code looks good; no qualifying findings. Verdict: correct.
eb35b56 to
c3e10f4
Compare
Problem
The Node v2 compliance adapter cannot yet exercise server identify and alias delivery in the existing acceptance features.
Changes
/identifyand/aliasroutes to the compliance adapter only. Identify mapsdistinct_idtodistinctIdand wraps the literal suppliedsetunder publicproperties.$set; alias maps the previousdistinct_idand targetaliasto the public SDK call. Preserve omitted values, native errors and native void results.Release info Sub-libraries affected
Libraries affected
No publishable SDK library changed; the changes are limited to
compliance/node/v2. No changeset or SDK version bump.Checklist
Validation
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
The human directed the public-delivery approach and chose to update existing acceptance features. Pi coding agent and a read-only reviewer assisted with the adapter, controlled and installed-package tests, and cross-repository validation. The agent session is local and not publicly linked. @dustinbyrne is the DRI.