fix(desktop): upload only newly added attachments - #76404
Open
puemos wants to merge 3 commits into
Open
Conversation
Generated-By: PostHog Code Task-Id: 7e2fad58-f738-4329-bc9f-d7f22ca44b28
Generated-By: PostHog Code Task-Id: 7e2fad58-f738-4329-bc9f-d7f22ca44b28
Generated-By: PostHog Code Task-Id: 7e2fad58-f738-4329-bc9f-d7f22ca44b28
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Contained frontend fix to desktop attachment upload state tracking, authored by the owning team with tests added; no risky territory touched and nothing in reviews/comments blocks it.
- 👍 on the PR from hex-security-app[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 61L, 1F substantive, 82L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (82L, 2F, single-area, fix) |
| stamphog 2.0.0b4 | .stamphog/policy.yml @ 96e2437 · reviewed head 51739a3 |
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adding another composer attachment restarted the loading state for every existing attachment because the full attachment list was treated as a new upload batch.
Changes
Upload only attachments added since the previous composer change. Per-upload tokens keep overlapping uploads race-safe without global request counters.
Why: Existing attachments should remain settled when another file is attached.
How did you test this code?
Automatic notifications
Docs update
No documentation changes needed.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Codex traced the loader behavior to the composer attachment-change callback and implemented the requested focused fix. No repo-provided skills were invoked.
Created with PostHog Code