chore(desktop): rename inbox signal source group to "External sources" - #76579
Conversation
Matches the "Connected tools"/"External sources" naming used in the main app so the inbox signal-sources section is consistent across surfaces. Label-only change, no behavior change. Generated-By: PostHog Code Task-Id: 40710cb7-2e49-43a6-b7a9-2812ca5250ae
|
😎 Merged successfully - details. |
|
Hey @joshsny! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
There was a problem hiding this comment.
Pull request overview
This PR aligns the Desktop Self-driving Inbox signal-sources grouping label with the intended naming by renaming the “External connections” header to “External sources” (including the loading skeleton), keeping the “PostHog data” vs “External sources” grouping consistent.
Changes:
- Rename the external integrations group header from “External connections” to “External sources”.
- Apply the same rename to the loading skeleton header.
- Update the nearby developer comment to match the new label.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Reviews (1): Last reviewed commit: "chore(desktop): rename inbox signal sour..." | Re-trigger Greptile |
|
React Doctor found 11 issues in 3 files · 11 warnings. 11 warnings
Reviewed by React Doctor for commit |
|
/trunk merge |
Problem
The inbox signal-sources section groups external integrations under a header that does not match its counterpart in the main PostHog app ("Connected tools" there, "External connections" here). The naming should be consistent across both surfaces.
This is a port of PostHog/code#3967, which was approved and green but can never merge: PostHog/code is now frozen behind a "block all PRs" ruleset after the monorepo migration, so the ref cannot be updated there.
Changes
Renames the signal-sources group header (and its loading skeleton) from External connections to External sources, matching the sibling "PostHog data" group.
How did you test this code?
I (actually the PostHog Slack agent) did not run the app or any tests for this. It is a two-string copy change in one component, ported byte-for-byte from the already-approved and fully-green PostHog/code#3967, and I verified by grep that the live header and the skeleton header are the only occurrences.
Automatic notifications
🤖 Agent context
Human-driven (agent-assisted). Ported by the PostHog Slack agent at the request of the original PR's author, who is assigned as DRI.
Created with PostHog from a Slack thread