Clean up main model: migrate out "prepare calculation" related stuff #1168
Conversation
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
figueroa1395
added
improvement
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Outdated
Show resolved
Hide resolved
| : system_frequency_{system_frequency}, | ||
| meta_data_{&input_data.meta_data()}, | ||
| math_solver_dispatcher_{&math_solver_dispatcher} { | ||
| solver_preparation_context_{.math_solver_dispatcher = &math_solver_dispatcher} { |
There was a problem hiding this comment.
This construction can IMO go to MainModel instead of MainModelImpl just like JobDispatcher
There was a problem hiding this comment.
I addressed this in 66e5449. There are now some additional dependencies to prepare_calculate.hpp which I'm not a fan of, but I suppose that should be fine because it's only temporal until we really get rid of MainModelImpl. Thoughts?
| namespace power_grid_model { | ||
| struct SolverPreparationContext { | ||
| main_core::MathState math_state; | ||
| Idx n_math_solvers{0}; |
There was a problem hiding this comment.
Is it required to keep n_math_solvers?
Is it ever not equivalent to math_state.topology.size()?
There was a problem hiding this comment.
I removed it (in 4f0d589) in favor of a helper function that does the calling from state.math_topology.size() indeed. It should be fine and
assert(n_math_solvers == static_cast<Idx>(main_core::get_y_bus<sym>(solver_context.math_state).size()));|
still remains as a sanity check.
Let me know what you think.
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
|
3 participants
This is an experimentation PR aimed to remove all the stuff related to preparing the calculation/solvers out of the main model. This PR should be an enabler to unit test the touched logic more easily, keep trimming the main model, and get it ready to remove everything related to the calculation logic in a followup.
At this stage I'm gathering input. I will address and update accordingly.