BugFix: fast_any_tap can not handle small u_band (smaller than tap_size)
#1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the fast_any_tap strategy where the binary search logic fails to handle edge cases when u_band is significantly smaller than tap_size. The fix ensures that fast_any_tap now correctly throws a MaxIterationReached error in cases equivalent to other strategies, aligning behavior across different tap-changing strategies.
Key changes:
- Modified binary search logic to detect when no valid tap position exists within the search range
- Added validation to throw
MaxIterationReachedwhen the search cannot converge - Added test cases for both
fast_any_tapandany_valid_tapstrategies with extremely smallu_bandvalues
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| power_grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp | Adds rewind method and validation logic to detect invalid tap positions in binary search |
| tests/data/power_flow/automatic-tap-regulator/auto-tap-changer-repro-fast-any/* | Test case for fast_any_tap strategy with unrealistically small u_band (0.00001) expecting MaxIterationReached |
| tests/data/power_flow/automatic-tap-regulator/auto-tap-changer-repro-any/* | Test case for any_valid_tap strategy with same configuration for comparison |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
nitbharambe
reviewed
Oct 27, 2025
tests/data/power_flow/automatic-tap-regulator/auto-tap-changer-meshed-any-max-iter/params.json
Outdated
Show resolved
Hide resolved
…-meshed-any-max-iter/params.json Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary search logic in any mode can not handle edge case when
u_bandis significantly smaller thantap_sizedue to the lack of back-forth jumping behavior. This PR fixes that andfast_any_tapstrategy now correctly throws aMaxIterationReachederror in equivalent cases as other strategies do.Note: the edge case is in itself not a valid input, as unrealistic
u_bandshouldn't be allowed, this PR aligns the behavior across different strategies.This PR relates to #887