Documentation: automatic tap changer behavior #1170
Conversation
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Jerry-Jinfeng-Guo
added
the
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation explaining the behavior and error handling of automatic tap changers in power grid calculations, specifically detailing when and why the MaxIterationReached error occurs.
Key Changes:
- Adds a new section documenting the
MaxIterationReachederror type for tap changers - Explains the two failure scenarios and their relationship to search methods (linear and binary)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Jerry Guo <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
docs/user_manual/calculations.md
Outdated
| In the case of an unrealistically set volatage and `u_band`, the viable voltage range regulatable can fall outside | ||
| this target band. | ||
| This will lead the regulator returning the tap that results in the closest voltage level to the target band. |
There was a problem hiding this comment.
Is this the behavior changed in https://github.com/PowerGridModel/power-grid-model/pull/1169/files?
Where originally it gave error and now it does not?
There was a problem hiding this comment.
This has been the behavior of all strategies all along.
It didn't not throw an error and does not either.
The bugfix fixes the absence of MaxIterReached equivalence for fast_any_tap.
Co-authored-by: Santiago Figueroa Manrique <[email protected]> Signed-off-by: Jerry Guo <[email protected]>
Co-authored-by: Santiago Figueroa Manrique <[email protected]> Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jerry Guo <[email protected]>
|
Added exception expectation section for the tap changer