Fixes #174. Changing Filter does not undo previously marked items #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tyler James Leonhardt <[email protected]>
andyleejordan
requested changes
May 2, 2023
|
|
||
| if (_listViewSource != null) { | ||
| _listViewSource.MarkChanged -= ListViewSource_MarkChanged; | ||
| _listViewSource = null; |
There was a problem hiding this comment.
Just noting that I think we're relying on the garbage collector to dispose of the previously created _listViewSource here. I think that's fine? If _listViewSource is disposable, we should do that. I'm not sure if it is though...will find out soon I guess.
There was a problem hiding this comment.
Ok we're good! It is not Disposable, it's an implementation of IListDataSource (which is a simple interface with just primitives and methods) and it holds a List<GridViewRow> which is managed only and thus not disposable.
andyleejordan
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #174.
PR Context
This addresses #174 (changing the filter caused marked items to get unmarked) by: