Marked are now at top; simplified code; fixed margin #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@tig after merging this, should I get a release out? |
|
Yes, I think this is all ready and I have nothing else I'm planning on fixing in the short term. Next on my list is #127 Not sure when I'll get to it though. |
|
I'll get on it! Thanks so much @tig. |
|
The fix looks great! First tests did not show any problem so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In #174, my fix didn't put the marked items at the top of the filtered list. @MrFly22 duly noted this.
The fix needed me to iterate of the input list twice (I could have added complexity to make this more efficient but decided until someone complains about perf...). There's now two simple Linq statements that do the trick
I noticed a related bug in my testing. When the filter has an invalid regex, we were just setting the ListView to the source list. In addition, the logic around what an empty filter string means was confused. I fixed these issues.
Finally, the extra space at the end of the filter edit and the wasteful margins around the listview have been driving me nuts.
PR Context